game/technic.git

Quarry: Fix server freeze when max depth is reduced (#487)

Thomas Rudin

2019-03-02 c14521cbd226073f1cf553e0f518863ce7f7e51a

commit \| author \| age
ee0765	1
be2f30	2	local S = technic.getter
S	3
0e9caf	4	local tube_entry = "^pipeworks_tube_connection_metallic.png"
54004f	5	local cable_entry = "^technic_cable_connection_overlay.png"
0e9caf	6
ee0765	7	minetest.register_craft({
S	8	recipe = {
5e4a87	9	{"technic:carbon_plate", "pipeworks:filter", "technic:composite_plate"},
44cb8d	10	{"basic_materials:motor", "technic:machine_casing", "technic:diamond_drill_head"},
83c649	11	{"technic:carbon_steel_block", "technic:hv_cable", "technic:carbon_steel_block"}},
ee0765	12	output = "technic:quarry",
S	13	})
	14
	15	local quarry_dig_above_nodes = 3 -- How far above the quarry we will dig nodes
	16	local quarry_max_depth = 100
d0efa1	17	local quarry_demand = 10000
428b1b	18	local quarry_eject_dir = vector.new(0, 1, 0)
ee0765	19
b74c2d	20	local function set_quarry_formspec(meta)
d0efa1	21	local radius = meta:get_int("size")
86dd58	22	local formspec = "size[6,4.3]"..
E	23	"list[context;cache;0,1;4,3;]"..
	24	"item_image[4.8,0;1,1;technic:quarry]"..
	25	"label[0,0.2;"..S("%s Quarry"):format("HV").."]"..
	26	"field[4.3,3.5;2,1;size;"..S("Radius:")..";"..radius.."]"
b74c2d	27	if meta:get_int("enabled") == 0 then
86dd58	28	formspec = formspec.."button[4,1;2,1;enable;"..S("Disabled").."]"
b74c2d	29	else
86dd58	30	formspec = formspec.."button[4,1;2,1;disable;"..S("Enabled").."]"
b74c2d	31	end
d0efa1	32	local diameter = radius*2 + 1
Z	33	local nd = meta:get_int("dug")
	34	local rel_y = quarry_dig_above_nodes - math.floor(nd / (diameter*diameter))
86dd58	35	formspec = formspec.."label[0,4;"..minetest.formspec_escape(
d0efa1	36	nd == 0 and S("Digging not started") or
Z	37	(rel_y < -quarry_max_depth and S("Digging finished") or
86dd58	38	(meta:get_int("purge_on") == 1 and S("Purging cache") or
d0efa1	39	S("Digging %d m "..(rel_y > 0 and "above" or "below").." machine")
86dd58	40	:format(math.abs(rel_y))))
d0efa1	41	).."]"
Z	42	formspec = formspec.."button[4,2;2,1;restart;"..S("Restart").."]"
b74c2d	43	meta:set_string("formspec", formspec)
d0efa1	44	end
Z	45
	46	local function set_quarry_demand(meta)
	47	local radius = meta:get_int("size")
	48	local diameter = radius*2 + 1
	49	local machine_name = S("%s Quarry"):format("HV")
86dd58	50	if meta:get_int("enabled") == 0 or meta:get_int("purge_on") == 1 then
E	51	meta:set_string("infotext", S(meta:get_int("purge_on") == 1 and "%s purging cache" or "%s Disabled"):format(machine_name))
d0efa1	52	meta:set_int("HV_EU_demand", 0)
Z	53	elseif meta:get_int("dug") == diameterdiameter (quarry_dig_above_nodes+1+quarry_max_depth) then
	54	meta:set_string("infotext", S("%s Finished"):format(machine_name))
	55	meta:set_int("HV_EU_demand", 0)
	56	else
	57	meta:set_string("infotext", S(meta:get_int("HV_EU_input") >= quarry_demand and "%s Active" or "%s Unpowered"):format(machine_name))
	58	meta:set_int("HV_EU_demand", quarry_demand)
	59	end
ee0765	60	end
S	61
	62	local function quarry_receive_fields(pos, formname, fields, sender)
	63	local meta = minetest.get_meta(pos)
d0efa1	64	if fields.size and string.find(fields.size, "^[0-9]+$") then
Z	65	local size = tonumber(fields.size)
	66	if size >= 2 and size <= 8 and size ~= meta:get_int("size") then
	67	meta:set_int("size", size)
	68	meta:set_int("dug", 0)
	69	end
ee0765	70	end
b74c2d	71	if fields.enable then meta:set_int("enabled", 1) end
Z	72	if fields.disable then meta:set_int("enabled", 0) end
86dd58	73	if fields.restart then
E	74	meta:set_int("dug", 0)
	75	meta:set_int("purge_on", 1)
	76	end
b74c2d	77	set_quarry_formspec(meta)
d0efa1	78	set_quarry_demand(meta)
ee0765	79	end
S	80
86dd58	81	local function quarry_handle_purge(pos)
E	82	local meta = minetest.get_meta(pos)
	83	local inv = meta:get_inventory()
	84	local i = 0
	85	for _,stack in ipairs(inv:get_list("cache")) do
	86	i = i + 1
	87	if stack then
	88	local item = stack:to_table()
	89	if item then
428b1b	90	technic.tube_inject_item(pos, pos, quarry_eject_dir, item)
86dd58	91	stack:clear()
E	92	inv:set_stack("cache", i, stack)
	93	break
	94	end
	95	end
	96	end
	97	if inv:is_empty("cache") then
	98	meta:set_int("purge_on", 0)
	99	end
	100	end
	101
d0efa1	102	local function quarry_run(pos, node)
ee0765	103	local meta = minetest.get_meta(pos)
86dd58	104	local inv = meta:get_inventory()
E	105	-- initialize cache for the case we load an older world
	106	inv:set_size("cache", 12)
	107	-- toss a coin whether we do an automatic purge. Chance 1:200
	108	local purge_rand = math.random()
	109	if purge_rand <= 0.005 then
	110	meta:set_int("purge_on", 1)
	111	end
	112
	113	if meta:get_int("enabled") and meta:get_int("HV_EU_input") >= quarry_demand and meta:get_int("purge_on") == 0 then
d0efa1	114	local pdir = minetest.facedir_to_dir(node.param2)
701240	115	if pdir.y ~= 0 then
TR	116	-- faces up or down, not valid, otherwise depth-check would run endless and hang up the server
	117	return
	118	end
	119
d0efa1	120	local qdir = pdir.x == 1 and vector.new(0,0,-1) or
Z	121	(pdir.z == -1 and vector.new(-1,0,0) or
	122	(pdir.x == -1 and vector.new(0,0,1) or
	123	vector.new(1,0,0)))
	124	local radius = meta:get_int("size")
	125	local diameter = radius*2 + 1
	126	local startpos = vector.add(vector.add(vector.add(pos,
	127	vector.new(0, quarry_dig_above_nodes, 0)),
	128	pdir),
	129	vector.multiply(qdir, -radius))
	130	local owner = meta:get_string("owner")
	131	local nd = meta:get_int("dug")
c14521	132	while nd < diameterdiameter (quarry_dig_above_nodes+1+quarry_max_depth) do
d0efa1	133	local ry = math.floor(nd / (diameter*diameter))
Z	134	local ndl = nd % (diameter*diameter)
	135	if ry % 2 == 1 then
	136	ndl = diameter*diameter - 1 - ndl
	137	end
	138	local rq = math.floor(ndl / diameter)
	139	local rp = ndl % diameter
	140	if rq % 2 == 1 then rp = diameter - 1 - rp end
	141	local digpos = vector.add(vector.add(vector.add(startpos,
	142	vector.new(0, -ry, 0)),
	143	vector.multiply(pdir, rp)),
	144	vector.multiply(qdir, rq))
	145	local can_dig = true
	146	if can_dig and minetest.is_protected and minetest.is_protected(digpos, owner) then
	147	can_dig = false
	148	end
	149	local dignode
	150	if can_dig then
c38da0	151	dignode = technic.get_or_load_node(digpos) or minetest.get_node(digpos)
d0efa1	152	local dignodedef = minetest.registered_nodes[dignode.name] or {diggable=false}
c93bfe	153	-- doors mod among other thing does NOT like a nil digger...
3d52b6	154	local fakedigger = pipeworks.create_fake_player({
TR	155	name = owner
	156	})
c93bfe	157	if not dignodedef.diggable or (dignodedef.can_dig and not dignodedef.can_dig(digpos, fakedigger)) then
d0efa1	158	can_dig = false
Z	159	end
	160	end
c38da0	161
E	162	if can_dig then
	163	for ay = startpos.y, digpos.y+1, -1 do
	164	local checkpos = {x=digpos.x, y=ay, z=digpos.z}
	165	local checknode = technic.get_or_load_node(checkpos) or minetest.get_node(checkpos)
	166	if checknode.name ~= "air" then
	167	can_dig = false
	168	break
	169	end
	170	end
	171	end
d0efa1	172	nd = nd + 1
Z	173	if can_dig then
	174	minetest.remove_node(digpos)
86dd58	175	local drops = minetest.get_node_drops(dignode.name, "")
E	176	for _, dropped_item in ipairs(drops) do
	177	local left = inv:add_item("cache", dropped_item)
	178	while not left:is_empty() do
	179	meta:set_int("purge_on", 1)
	180	quarry_handle_purge(pos)
	181	left = inv:add_item("cache", left)
	182	end
d0efa1	183	end
Z	184	break
	185	end
ee0765	186	end
86dd58	187	if nd == diameterdiameter (quarry_dig_above_nodes+1+quarry_max_depth) then
E	188	-- if a quarry is finished, we enable purge mode
	189	meta:set_int("purge_on", 1)
	190	end
d0efa1	191	meta:set_int("dug", nd)
86dd58	192	else
E	193	-- if a quarry is disabled or has no power, we enable purge mode
	194	meta:set_int("purge_on", 1)
	195	end
	196	-- if something triggered a purge, we handle it
	197	if meta:get_int("purge_on") == 1 then
	198	quarry_handle_purge(pos)
ee0765	199	end
d0efa1	200	set_quarry_formspec(meta)
Z	201	set_quarry_demand(meta)
86dd58	202	end
E	203
	204	local function send_move_error(player)
	205	minetest.chat_send_player(player:get_player_name(),
	206	S("Manually taking/removing from cache by hand is not possible. "..
	207	"If you can't wait, restart or disable the quarry to start automatic purge."))
	208	return 0
563a4c	209	end
N	210
ee0765	211	minetest.register_node("technic:quarry", {
7c4b70	212	description = S("%s Quarry"):format("HV"),
0e9caf	213	tiles = {
VE	214	"technic_carbon_steel_block.png"..tube_entry,
54004f	215	"technic_carbon_steel_block.png"..cable_entry,
VE	216	"technic_carbon_steel_block.png"..cable_entry,
	217	"technic_carbon_steel_block.png"..cable_entry,
0e9caf	218	"technic_carbon_steel_block.png^default_tool_mesepick.png",
54004f	219	"technic_carbon_steel_block.png"..cable_entry
0e9caf	220	},
ee0765	221	paramtype2 = "facedir",
83c649	222	groups = {cracky=2, tubedevice=1, technic_machine=1, technic_hv=1},
S	223	connect_sides = {"bottom", "front", "left", "right"},
ee0765	224	tube = {
S	225	connect_sides = {top = 1},
428b1b	226	-- lower priority than other tubes, so that quarries will prefer any
T	227	-- other tube to another quarry, which could lead to server freezes
	228	-- in certain quarry placements (2x2 for example would never eject)
	229	priority = 10,
	230	can_go = function(pos, node, velocity, stack)
	231	-- always eject the same, even if items came in another way
	232	-- this further mitigates loops and generally avoids random sideway movement
	233	-- that can be expected in certain quarry placements
	234	return { quarry_eject_dir }
	235	end
ee0765	236	},
S	237	on_construct = function(pos)
	238	local meta = minetest.get_meta(pos)
7c4b70	239	meta:set_string("infotext", S("%s Quarry"):format("HV"))
b74c2d	240	meta:set_int("size", 4)
Z	241	set_quarry_formspec(meta)
d0efa1	242	set_quarry_demand(meta)
ee0765	243	end,
S	244	after_place_node = function(pos, placer, itemstack)
	245	local meta = minetest.get_meta(pos)
	246	meta:set_string("owner", placer:get_player_name())
ae235e	247	pipeworks.scan_for_tube_objects(pos)
ee0765	248	end,
86dd58	249	can_dig = function(pos,player)
E	250	local meta = minetest.get_meta(pos);
	251	local inv = meta:get_inventory()
	252	return inv:is_empty("cache")
	253	end,
ae235e	254	after_dig_node = pipeworks.scan_for_tube_objects,
ee0765	255	on_receive_fields = quarry_receive_fields,
d0efa1	256	technic_run = quarry_run,
86dd58	257	allow_metadata_inventory_move = function(pos, from_list, from_index, to_list, to_index, count, player)
E	258	return send_move_error(player)
	259	end,
	260	allow_metadata_inventory_put = function(pos, listname, index, stack, player)
	261	return send_move_error(player)
	262	end,
	263	allow_metadata_inventory_take = function(pos, listname, index, stack, player)
	264	return send_move_error(player)
	265	end
ee0765	266	})
S	267
	268	technic.register_machine("HV", "technic:quarry", technic.receiver)