Fix warning reported by LuaCheck (#563)

David Leal

2020-09-05 11f2b4f4b317a25972733e3d3fe9f2dc6ce31c6a

 technic/tools/mining_drill.lua

@@ -6,8 +6,8 @@
minetest.register_craft({
   output = 'technic:mining_drill',
   recipe = {
      {'moreores:tin_ingot',            'technic:diamond_drill_head', 'moreores:tin_ingot'},
      {'technic:stainless_steel_ingot', 'technic:motor',              'technic:stainless_steel_ingot'},
      {'default:tin_ingot',             'technic:diamond_drill_head', 'default:tin_ingot'},
      {'technic:stainless_steel_ingot', 'basic_materials:motor',              'technic:stainless_steel_ingot'},
      {'',                              'technic:red_energy_crystal', 'default:copper_ingot'},
   }
})
@@ -51,18 +51,20 @@
      minetest.record_protection_violation(pos, player:get_player_name())
      return
   end
   local node=minetest.get_node(pos)
   local node = minetest.get_node(pos)
   if node.name == "air" or node.name == "ignore" then return end
   if node.name == "default:lava_source" then return end
   if node.name == "default:lava_flowing" then return end
   if node.name == "default:water_source" then minetest.remove_node(pos) return end
   if node.name == "default:water_flowing" then minetest.remove_node(pos) return end
   minetest.node_dig(pos,node,player)
   local def = minetest.registered_nodes[node.name]
   if not def then return end
   def.on_dig(pos, node, player)
end

local function drill_dig_it1 (player)
   local dir=player:get_look_dir()
   if math.abs(dir.x)>math.abs(dir.z) then 
   if math.abs(dir.x)>math.abs(dir.z) then
      if dir.x>0 then return 0 end
      return 1
   end
@@ -71,12 +73,6 @@
end

local function drill_dig_it2 (pos,player)
   drill_dig_it0 (pos,player)
   pos.z=pos.z+1
   drill_dig_it0 (pos,player)
   pos.z=pos.z-2
   drill_dig_it0 (pos,player)
   pos.z=pos.z+1
   pos.y=pos.y+1
   drill_dig_it0 (pos,player)
   pos.z=pos.z+1
@@ -84,7 +80,14 @@
   pos.z=pos.z-2
   drill_dig_it0 (pos,player)
   pos.z=pos.z+1
   pos.y=pos.y-2
   pos.y=pos.y-1
   drill_dig_it0 (pos,player)
   pos.z=pos.z+1
   drill_dig_it0 (pos,player)
   pos.z=pos.z-2
   drill_dig_it0 (pos,player)
   pos.z=pos.z+1
   pos.y=pos.y-1
   drill_dig_it0 (pos,player)
   pos.z=pos.z+1
   drill_dig_it0 (pos,player)
@@ -93,12 +96,6 @@
end

local function drill_dig_it3 (pos,player)
   drill_dig_it0 (pos,player)
   pos.x=pos.x+1
   drill_dig_it0 (pos,player)
   pos.x=pos.x-2
   drill_dig_it0 (pos,player)
   pos.x=pos.x+1
   pos.y=pos.y+1
   drill_dig_it0 (pos,player)
   pos.x=pos.x+1
@@ -106,7 +103,14 @@
   pos.x=pos.x-2
   drill_dig_it0 (pos,player)
   pos.x=pos.x+1
   pos.y=pos.y-2
   pos.y=pos.y-1
   drill_dig_it0 (pos,player)
   pos.x=pos.x+1
   drill_dig_it0 (pos,player)
   pos.x=pos.x-2
   drill_dig_it0 (pos,player)
   pos.x=pos.x+1
   pos.y=pos.y-1
   drill_dig_it0 (pos,player)
   pos.x=pos.x+1
   drill_dig_it0 (pos,player)
@@ -152,9 +156,9 @@
   if mode == 1 then
      drill_dig_it0(pos, player)
   end
	

   if mode == 2 then -- 3 deep
      dir = drill_dig_it1(player)
      local dir = drill_dig_it1(player)
      if dir == 0 then -- x+
         drill_dig_it0(pos, player)
         pos.x = pos.x + 1
@@ -184,9 +188,9 @@
         drill_dig_it0 (pos,player)
      end
   end
	

   if mode==3 then -- 3 wide
      dir=drill_dig_it1(player)
      local dir = drill_dig_it1(player)
      if dir==0 or dir==1 then -- x
         drill_dig_it0 (pos,player)
         pos.z=pos.z+1
@@ -202,7 +206,7 @@
         drill_dig_it0 (pos,player)
      end
   end
	

   if mode==4 then -- 3 tall, selected in the middle
      drill_dig_it0 (pos,player)
      pos.y=pos.y-1
@@ -225,7 +229,7 @@
      drill_dig_it4(pos,player)
      end
   end
	

   minetest.sound_play("mining_drill", {pos = pos, gain = 1.0, max_hear_distance = 10,})
end

@@ -238,6 +242,7 @@
local function mining_drill_mk2_setmode(user,itemstack)
   local player_name=user:get_player_name()
   local item=itemstack:to_table()
   local mode = nil
   local meta=minetest.deserialize(item["metadata"])
   if meta==nil then
      meta={}
@@ -284,7 +289,6 @@

local function mining_drill_mk2_handler(itemstack, user, pointed_thing)
   local keys = user:get_player_control()
   local player_name = user:get_player_name()
   local meta = minetest.deserialize(itemstack:get_metadata())
   if not meta or not meta.mode or keys.sneak then
      return mining_drill_mk2_setmode(user, itemstack)
@@ -307,7 +311,6 @@

local function mining_drill_mk3_handler(itemstack, user, pointed_thing)
   local keys = user:get_player_control()
   local player_name = user:get_player_name()
   local meta = minetest.deserialize(itemstack:get_metadata())
   if not meta or not meta.mode or keys.sneak then
      return mining_drill_mk3_setmode(user, itemstack)