From 40302288abc170ebfd2b7ffacb334768f77b8698 Mon Sep 17 00:00:00 2001
From: filippo.bertilotti <filippobertilotti@gmail.com>
Date: Tue, 30 Apr 2024 12:10:03 +0200
Subject: [PATCH] refactor

---
 htdocs/contact.php |   32 +++++++++++++++++---------------
 1 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/htdocs/contact.php b/htdocs/contact.php
index 49a1de5..9a09725 100644
--- a/htdocs/contact.php
+++ b/htdocs/contact.php
@@ -7,7 +7,7 @@
     $smarty->setCompileDir('../compile');
 
     $errorMsgs = [];
-    $errorCheck = false;
+    $validazioneOk = true;
 
     $number = $_POST['number'] ?? '';
     $email = $_POST['email'] ?? '';
@@ -15,54 +15,54 @@
 
 
     function insertDataOnTable(mysqli $mysql, string $email, string $number) { 
+        $esitoInserimento = false;
         $query = "INSERT INTO Contact VALUES (NULL, '$email', '$number');";
         try {
             $mysql->query($query);
+            $esitoInserimento = true;
         } catch (Exception $e) {
             echo $e->getMessage();
         }
+        return $esitoInserimento;
     }
 
     function controlloErrori(string $email, string $number, array &$errorMsgs) {
         if(!is_numeric($number) || strlen($number) != 10) {
             $errorMsgs['number'] = 'Numero di telefono non corretto';
-            $errorCheck = true;
-
         }else {
             //$errorMsgs['number'] = '';
-            $errorCheck = false;
         }
     
         if(!filter_var($email, FILTER_VALIDATE_EMAIL)) {
             $errorMsgs['email'] = 'Email non valida';
-            $errorCheck = true;
         } else {
             //$errorMsgs['email'] = '';
-            $errorCheck = false;
         }
 
-        return $errorCheck;
+        $validazioneOk = count($errorMsgs) == 0;
+
+        return $validazioneOk;
     }
     
 
 
     if($_SERVER['REQUEST_METHOD'] === 'POST') {
-        $errorCheck = controlloErrori($email, $number, $errorMsgs);
+        $validazioneOk = controlloErrori($email, $number, $errorMsgs);
 
-        if(count($errorMsgs) == 0) {
+        if($validazioneOk) {
             try {
                 $conn = new mysqli('127.0.0.1', 'root', '', 'contact_db');
             } catch (Exception $e) {
                 die($e->getMessage());
             }
 
-            insertDataOnTable($conn, $email, $number);
-        }
+            $esitoInserimento = insertDataOnTable($conn, $email, $number);
 
-        if ($errorCheck == false) {
-            $msg = "La contattatteremo presto!";
+            if($esitoInserimento == true) {
+                $smarty->display('conferma.tpl');
+                exit;
+            }
         }
-        
     }
     
     
@@ -70,8 +70,10 @@
     $smarty->assign('cellNumber', $number);
     $smarty->assign('email', $email);
     $smarty->assign('formMsg', $msg);
-
+    
     $smarty->assign('errorMsgs', $errorMsgs);
 
     $smarty->display('contact.tpl');
+  
+    
 ?>
\ No newline at end of file

--
Gitblit v1.8.0